Skip to content

KC-1346: Fix misleading communication error when assigning team to admin role#2220

Merged
sk-keeper merged 1 commit into
releasefrom
KC-1346
Jul 16, 2026
Merged

KC-1346: Fix misleading communication error when assigning team to admin role#2220
sk-keeper merged 1 commit into
releasefrom
KC-1346

Conversation

@sshrushanth-ks

Copy link
Copy Markdown
Contributor

Summary

enterprise-team -ar showed the correct admin-role validation message but then also raised a misleading communication error. The API was still called with an empty RoleTeams payload after validation filtered out admin roles. This fix skips the API call when there are no role-team entries to send.

Changes

  • enterprise_common.py — only call role_team_add / role_team_remove when role_team is non-empty in change_team_roles and change_role_teams
  • test_enterprise_role_team_validation.py — added tests confirming no API call is made when assigning a team to an admin role

…min role (#2209)

* Fix misleading communication error when assigning team to admin role

* fixed unit test file

* removed team details from response after warning is displayed
@sshrushanth-ks sshrushanth-ks self-assigned this Jul 16, 2026
@sshrushanth-ks
sshrushanth-ks marked this pull request as ready for review July 16, 2026 10:29
@sk-keeper
sk-keeper merged commit ac9d788 into release Jul 16, 2026
4 checks passed
@sk-keeper
sk-keeper deleted the KC-1346 branch July 16, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants